Remove react platform and lint tests #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(tests): lint test files
rolandszoke
changed the title
solkimicreb
reviewed
Feb 25, 2020
| @@ -1,5 +1,6 @@ | |||
| import React, { Component } from 'react'; | |||
| import { render, cleanup, act } from '@testing-library/react/pure'; | |||
| // eslint-disable-next-line import/no-unresolved | |||
There was a problem hiding this comment.
Does the linter cry because of the linking/mocking here?
There was a problem hiding this comment.
It cries because react-easy-state is not installed as a node package. It is only linked, and eslint cannot see that sadly.
solkimicreb
approved these changes
Feb 25, 2020
|
Thanks! |
|
🎉 This PR is included in version 6.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed react-platform.
Had to leave react-dom and react-native in as dev deps since our testing libraries use them as peer deps.